[DRAFT] Allow a default for optional interpolations #80547
Draft
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an `appendInterpolation` overload to `DefaultStringInterpolation`
that includes a parameter for providing a default string when the value
to interpolate is `nil`. This allows this kind of usage:
let age: Int? = nil
print("Your age is \(age, default: "timeless")")
// Prints "Your age is timeless"
Includes an additional fixit when optional values are interpolated to
use this `default:` parameter.
natecook1000
added
standard library
natecook1000
commented
Apr 4, 2025
| @@ -5688,6 +5688,11 @@ static void diagnoseUnintendedOptionalBehavior(const Expr *E, | |||
| .fixItInsertAfter(arg->getEndLoc(), ")"); | |||
|
|
|||
| if (kind == UnintendedInterpolationKind::Optional) { | |||
| // Suggest using a default interpolation value parameter. | |||
| Ctx.Diags.diagnose(arg->getLoc(), diag::default_optional_parameter) | |||
There was a problem hiding this comment.
@beccadax Do you know if it would be possible to only provide this fixit when the string interpolation type is DefaultStringInterpolation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
appendInterpolationoverload toDefaultStringInterpolationthat includes a parameter for providing a default string when the value to interpolate isnil. This allows this kind of usage:Includes an additional fixit when optional values are interpolated to use this
default:parameter.