[NFC] Sema: Factor out some sources into subdirectories #80529
Merged
+85
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
slavapestov,
xedin and
ktoso
as code owners
AnthonyLatsis
force-pushed
the
ammanita-pantherina
branch
from
9338d56 to
44a5fc8
Compare
xedin
approved these changes
Apr 4, 2025
hborla
reviewed
Apr 5, 2025
| @@ -1,8 +1,8 @@ | |||
| //===--- DerivedConformanceActor.cpp - Derived Actor Conformance ----------===// | |||
| //===--- DerivedConformance/Actor.cpp ---------------------------*- C++ -*-===// | |||
There was a problem hiding this comment.
I'm not a fan of having multiple files called Actor.cpp in the codebase. For example, if you have both open in different tabs, there's not a quick way to differentiate which is which.
There was a problem hiding this comment.
Let’s keep the old names then.
AnthonyLatsis
force-pushed
the
ammanita-pantherina
branch
from
44a5fc8 to
3fd8f0a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.