[Distributed] Accessor must be available cross module in resilient mode #80523
+265
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
force-pushed
the
wip-distributed-cross-module-resolvable-accessible-fun
branch
from
3c0e644 to
2b1290d
Compare
|
@swift-ci please test |
xedin
approved these changes
Apr 4, 2025
ktoso
force-pushed
the
wip-distributed-cross-module-resolvable-accessible-fun
branch
from
2b1290d to
cadd458
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test macOS |
This was referenced Apr 4, 2025
This is an important fix for libraries using @resolvable in resilient libraries. Without the fix we're missing an accessor and this will fail some remote calls which make use of remote calls on resolvable protocols. This would manifest as missing accessor error thrown by the executeDistributedTarget function. resolves rdar://148224780
ktoso
force-pushed
the
wip-distributed-cross-module-resolvable-accessible-fun
branch
from
cadd458 to
d7cd90d
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-cross-module-resolvable-accessible-fun
branch
from
d7cd90d to
a3644a2
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an important fix for libraries using
@Resolvablein resilient libraries. Without the fix we're missing an accessor and this will fail some remote calls which make use of remote calls on resolvable protocols. This would manifest as missing accessor error thrown by the executeDistributedTarget function.resolves rdar://148224780