Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Make sure to always use local package dependencies on Windows #79543

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Feb 21, 2025

This is the new underlying cause of swiftlang/swift-format#939 - swift-format now skips these tests if using local dependencies, but the environment variable wasn't actually being set.

@bnbarham
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough.

@bnbarham
Copy link
Contributor Author

swiftlang/sourcekit-lsp#1995

@swift-ci please test Windows platform

1 similar comment
@bnbarham
Copy link
Contributor Author

swiftlang/sourcekit-lsp#1995

@swift-ci please test Windows platform

@bnbarham
Copy link
Contributor Author

swiftlang/sourcekit-lsp#1995

@swift-ci please test Windows platform

@bnbarham bnbarham merged commit c6d1060 into swiftlang:main Feb 26, 2025
5 checks passed
@bnbarham bnbarham deleted the always-use-local-deps branch February 26, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants