Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Enable tests for LLDB in Swift CI #78844

Merged

Conversation

weliveindetail
Copy link
Member

#76894 prepared the toolchain build to run tests for LLDB in Swift CI. Here we just turn it on. In case we clog Swift PR testing, we can easily revert this one without loosing all the infrastructure.

@weliveindetail
Copy link
Member Author

@swift-ci please smoke test

@weliveindetail weliveindetail merged commit 7c821ed into swiftlang:main Jan 28, 2025
3 checks passed
@weliveindetail weliveindetail deleted the windows-start-testing-lldb branch January 28, 2025 13:11
@weliveindetail
Copy link
Member Author

The previous PR test https://ci-external.swift.org/job/swift-PR-windows/35709/ took 3h52min
The test for this PR https://ci-external.swift.org/job/swift-PR-windows/35710/ took 4h5min

As expected, LLDB added 5min to the llvm-project tests. Where are the remaining 8min coming from? Not clear. The log of the build step times below doesn't explain this gap. The accumulated times are 3:30:37 vs. 3:22:42. These 3min are in range of natural fluctuation, but we still miss 5min of extra runtime. We might want to add extra time tracking.

Screenshot 2025-01-28 at 14 58 50

@weliveindetail
Copy link
Member Author

weliveindetail commented Jan 28, 2025

If the Windows arm64 bot reports new failures, we want to add them to utils/windows-llvm-lit-test-overrides.txt. I am keeping an eye on https://ci-external.swift.org/job/swift-main-windows-toolchain-arm64/919/ and I hope it's done before the end of my day 🤞

Edit: swift-main-windows-toolchain bot don't run the LLDB tests right now, because their invocation is hardcoded. We have to wait for the maintainer to enable it. My gut feeling is that we should keep them enabled in PR-testing as long as there are not complaints about flakes. So far, random sampling didn't show any, but this way of monitoring is fragile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants