Commits on Oct 19, 2024

1. [SourceKit] Check if the realpath of a module is inside the SDK to de… …

   …cide if it's system
   
   On Windows, we run into the following situation when running SourceKit-LSP tests:
   - The SDK is located at `S:\Program Files\Swift\Platforms\Windows.platform\Developer\SDKs\Windows.sdk` with `S:` being a substitution drive
   - We find `Swift.swiftmodule` at `S:\Program Files\Swift\Platforms\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\windows\Swift.swiftmodule`
   - Now, to check if `Swift.swiftmodule` is a system module, we take the realpath of the SDK, which resolves the substitution drive an results in something like `C:\Users\alex\src\Program Files\Swift\Platforms\Windows.platform\Developer\SDKs\Windows.sdk`
   - Since we don’t take the realpath of `Swift.swiftmodule`, we will assume that it’s not in the SDK, because the SDK’s path is on `C:` while `Swift.swiftmodule` lives on `S:`
   
   To fix this, we also need to check if a module’s real path is inside the SDK.
   
   Fixes swiftlang/sourcekit-lsp#1770
   rdar://138210224

   

   ahoppen committed Oct 19, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for a287e2a
   • Browse repository at this point

   Copy the full SHA

   a287e2a View commit details

   Browse the repository at this point in the history