Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-script: add flag to pass arguments to dsymutil #72486

Merged
merged 1 commit into from
Mar 25, 2024
Merged

build-script: add flag to pass arguments to dsymutil #72486

merged 1 commit into from
Mar 25, 2024

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Mar 21, 2024

This is currently needed to disable DWARF verification in some Apple internal configurations.

Addresses rdar://125092216

@edymtt
Copy link
Contributor Author

edymtt commented Mar 21, 2024

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Mar 21, 2024

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Mar 21, 2024

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Mar 21, 2024

@swift-ci please test WebAssembly

@shahmishal shahmishal mentioned this pull request Mar 21, 2024
Merged
@edymtt
Copy link
Contributor Author

edymtt commented Mar 21, 2024

@swift-ci please build toolchain macOS

@edymtt
Copy link
Contributor Author

edymtt commented Mar 21, 2024

Please test with following pull request:
swiftlang/swift-integration-tests#133

@swift-ci please build toolchain macOS

compnerd
compnerd approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but perhaps we should name the parameter dsymutil-extra-args as they are appended.

@edymtt
build-script: add flag to pass arguments to dsymutil
efdd495 
This is currently needed to disable DWARF verification in
some Apple internal configurations.

Addresses rdar://125092216
@edymtt edymtt force-pushed the emiotto/add-flag-to-pass-arguments-to-dsymutil branch from f37f89e to efdd495 Compare March 22, 2024 15:04
@edymtt
Copy link
Contributor Author

edymtt commented Mar 22, 2024

Took @compnerd 's suggestion in efdd495 -- ended up renaming that to extra-dsymutil-args to match the existing extra-swift-args and extra-cmake-options flags.

@edymtt
Copy link
Contributor Author

edymtt commented Mar 22, 2024

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Mar 22, 2024

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Mar 22, 2024

@swift-ci please test WebAssembly

@edymtt
Copy link
Contributor Author

edymtt commented Mar 22, 2024

Please test with following pull request:
swiftlang/swift-integration-tests#133

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Mar 22, 2024

@swift-ci please test WebAssembly

@edymtt
Copy link
Contributor Author

edymtt commented Mar 22, 2024

@swift-ci please test Windows

@edymtt edymtt merged commit 0edd96e into swiftlang:main Mar 25, 2024
10 checks passed
@edymtt edymtt mentioned this pull request Mar 25, 2024
Merged
@edymtt edymtt deleted the emiotto/add-flag-to-pass-arguments-to-dsymutil branch March 27, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@187ram 187ram 187ram approved these changes

@shahmishal shahmishal shahmishal approved these changes

@etcwilde etcwilde etcwilde approved these changes

@JDevlieghere JDevlieghere JDevlieghere approved these changes

@compnerd compnerd compnerd approved these changes

@kubamracek kubamracek Awaiting requested review from kubamracek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@edymtt @compnerd @JDevlieghere @etcwilde @shahmishal @187ram