Improve the reliability of some tests on Linux #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This marks a couple tests that run `ps` as requiring that executable, since it's not normally installed by default in a Docker container. It also accounts for the fact that `ulimit -n` can be 2^20 in a Docker container, so we constrain concurrently spawned processes to an upper bound of 4096 instead.
lynchsft
approved these changes
Apr 28, 2025
iCharlesHu
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks a couple tests that run
psas requiring that executable, since it's not normally installed by default in a Docker container. It also accounts for the fact thatulimit -ncan be 2^20 in a Docker container, so we constrain concurrently spawned processes to an upper bound of 4096 instead.