-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all request kinds by default #155
base: main
Are you sure you want to change the base?
Conversation
As discussed offline, I would like to hold this back until I’ve merged #146. |
Stress tester run: https://ci.swift.org/job/swift-PR-macos-with-sourcekit-stress-tester/52/ |
Triggered a stress tester run in swiftlang/swift#37710. |
Between some unrelated failures, the stress tester has found a few module issues as well. I think that shows that having the stress tester test modules has a benefit, even though it increases the run time by 4 hours (previously 10 hours, now 14 hours). Once the failures are fixed I’m OK with merging this. |
@swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://ci.swift.org/job/swift-PR-macos-with-sourcekit-stress-tester/8/console only made a few code completion timeouts re-appear. I’m fine with merging this as-is. I’ll take care of xfailing the timeout issues when the start appearing in the nightly jobs.
@swift-ci please test |
1 similar comment
@swift-ci please test |
The latest run was successful. Given it hasn't run for a few months, I'm not convinced that it's worth the extra 2 hours to run this as well. Might just manually run every now and again, then reconsider if this does find any extra issues. |
Start running the test modules request as well.