-
Notifications
You must be signed in to change notification settings - Fork 1.4k
@testable cleanup #8826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
compnerd
wants to merge
46
commits into
swiftlang:main
Choose a base branch
from
compnerd:testable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
@testable cleanup #8826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
These do not require additonal APIs to be exposed, simply convert to regular import of the Basics module.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series cleans up the vast majority of the
@testable
importing in the tests. The one that remains is for X509 which is external to this package. I intend to introduce a SPI for that API surface to help remove the last of the@testable
importing.