Prevent unnecessary rebuilds when modifying swiftc arguments #8803
+125
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@plemarquand This is huge in certain situations. Does this also cover env vars, or only command line arguments? |
|
@MahdiBM This patch just covers |
owenv
approved these changes
Jun 13, 2025
jakepetroules
approved these changes
Jun 13, 2025
|
Great find. Thanks @plemarquand ! |
dschaefer2
approved these changes
Jun 13, 2025
plemarquand
force-pushed
the
no-swifc-args-rebuild
branch
from
cebebe3 to
8ef9f11
Compare
|
@swift-ci please test |
owenv
reviewed
Jun 17, 2025
| try RelativePath(validating: ".build") | ||
| .appending(triple) | ||
| .appending("Products") | ||
| .appending("Debug") |
There was a problem hiding this comment.
I'm pretty sure this path component will have a platform suffix everywhere except macOS, otherwise lgtm
Many arguments for the compiler are marked as `doesNotAffectIncrementalBuild` in `swift-driver`. Use the argument hashing in swift-driver to hash the swift compiler flags and incorporate that in to the build hash signature used to determine if SwiftPM should do a full rebuild. This prevents unnecssary rebuilds when adding or changing arguments like `-Xswiftc -diagnostic-style=llvm`. For a list of arguments that no longer affect rebuilds, search for `doesNotAffectIncrementalBuild` in https://github.com/swiftlang/swift-driver/blob/main/Sources/SwiftOptions/Options.swift. This builds on the work introduced in swiftlang#8717 which avoided unnecessary rebuilds when SwiftPM arguments changed.
plemarquand
force-pushed
the
no-swifc-args-rebuild
branch
from
8ef9f11 to
f59dcee
Compare
|
@swift-ci please test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many arguments for the compiler are marked as
doesNotAffectIncrementalBuildinswift-driver. Use the argument hashing in swift-driver to hash the swift compiler flags and incorporate that in to the build hash signature used to determine if SwiftPM should do a full rebuild.This prevents unnecssary rebuilds when adding or changing arguments like
-Xswiftc -diagnostic-style=llvm. For a list of arguments that no longer affect rebuilds, search fordoesNotAffectIncrementalBuildin https://github.com/swiftlang/swift-driver/blob/main/Sources/SwiftOptions/Options.swift.This builds on the work introduced in #8717 which avoided unnecessary rebuilds when SwiftPM arguments changed.