Avoid building targets that are conditional on platform when building all #8568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when building all
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci test Windows |
|
@swift-ci please test |
|
@swift-ci test Windows |
cmcgee1024
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri and
daveyc123
as code owners
jakepetroules
approved these changes
Apr 29, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the swiftbuild build system, and building all targets with a project
that contains a target that is depended on only when on a specific platform that
target should be skipped. Make the All(Excluding|Including)Tests generated
targets depend only on targets that are reachable from the roots through
dependencies that are either unconditional or are conditioned on the current
platform.