[6.1] Update build-using-self for CI. #8567
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just copied the files from main.
dschaefer2
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
bkhouri
requested changes
Apr 28, 2025
| shlex.split(f"swift build --configuration {args.config} {ignore}"), | ||
| ) | ||
|
|
||
| swift_testing_arg= "--enable-swift-testing" if args.enable_swift_testing else "" |
There was a problem hiding this comment.
Issue (blocking): Tests on this branch will fail on Windows as the work to enabled tests on Windows was only done on main.
The Windows self hosted pipeline was not meant to run on this branch.
Can we skip the tests on Windows only?
There was a problem hiding this comment.
Ah, true. No reason we can't run it here. I'll fix the tests to get them passing as we did on main.
There was a problem hiding this comment.
There will be be alot to disable ;)
|
And this is a duplicate of #8537 |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just copied the files from main.