Refactor slow to type check expression #8565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
xedin
reviewed
Apr 28, 2025
An expression SwiftRunCommand was taking almost 2 seconds to type check on my M4 MacBook. Explicitly type the enum cases so the type checker has less work to do. This brings the time to type this expression down to under 80ms to check. This was diagnosed with: ``` swift build \ -Xswiftc -Xfrontend -Xswiftc -warn-long-function-bodies=80 \ -Xswiftc -Xfrontend -Xswiftc -warn-long-expression-type-checking=80 ```
plemarquand
force-pushed
the
slow-typecheck-method
branch
from
1b73a99 to
34bff20
Compare
|
@swift-ci test |
|
@swift-ci test windows |
jakepetroules
approved these changes
Apr 29, 2025
|
@swift-ci test windows |
bkhouri
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
An expression in
SwiftRunCommandwas taking almost 2 seconds to type check on my M4 MacBook.Modifications:
Break it out in to multiple, faster to type check expressions.
Result:
This brings each individual expression down to under 80ms to check.
This was diagnosed with: