Test: Enable most AsyncProcessTests #8500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test self hosted windows |
|
@swift-ci please test self hosted |
bkhouri
force-pushed
the
t/main/fix_echo_command_in_windows_tests_gh8433_rdar148248105
branch
from
38a7f2f to
a253651
Compare
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
|
@swift-ci test |
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
MaxDesiatov
reviewed
Apr 16, 2025
MaxDesiatov
reviewed
Apr 16, 2025
MaxDesiatov
reviewed
Apr 16, 2025
bkhouri
force-pushed
the
t/main/fix_echo_command_in_windows_tests_gh8433_rdar148248105
branch
from
a253651 to
8312d6b
Compare
jakepetroules
approved these changes
Apr 17, 2025
|
@swift-ci test |
|
@swift-ci test self hosted windows |
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/fix_echo_command_in_windows_tests_gh8433_rdar148248105
branch
from
8312d6b to
c97ba8e
Compare
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test windows |
Enable all but 3 tests. Some AsyncProcessTests call to `cat` and `echo` commands. Update the executable to be called correctly on Windows via the `cmd.exe /c` command, where the `cat` equivalent is `type`, which displays the file contents. Also, many tests call a script. We created a batch file, which simply calls the associated script invoked by python. Only 3 tests remain skipped. - one failed assertion on Windows - two otheers appear to have caused `swift test` tp hang. Depends on: swiftlang#8495 Related to: swiftlang#8433 rdar://148248105
bkhouri
force-pushed
the
t/main/fix_echo_command_in_windows_tests_gh8433_rdar148248105
branch
from
c97ba8e to
f54edb2
Compare
|
@swift-ci test |
1 task
bkhouri
force-pushed
the
t/main/fix_echo_command_in_windows_tests_gh8433_rdar148248105
branch
from
f54edb2 to
e53fb23
Compare
|
@swift-ci test |
|
@swift-ci test linux |
bkhouri
force-pushed
the
t/main/fix_echo_command_in_windows_tests_gh8433_rdar148248105
branch
from
e53fb23 to
909c874
Compare
|
@swift-ci test |
|
@swift-ci test self hosted |
|
@swift-ci test |
dschaefer2
reviewed
Apr 28, 2025
| @@ -795,11 +795,17 @@ let package = Package( | |||
| "Archiver/Inputs/invalid_archive.tar.gz", | |||
| "Archiver/Inputs/invalid_archive.zip", | |||
| "processInputs/long-stdout-stderr", | |||
| "processInputs/long-stdout-stderr.bat", | |||
There was a problem hiding this comment.
Wouldn't it be simpler to call python on the python file on all platforms? ["python3", "long-stdout-stderr"]?
There was a problem hiding this comment.
That would require adding a host dependency on the test, and we are unable to guarantee that python will be installed on the host.
There was a problem hiding this comment.
But the bat scripts run python. And python is a dependency of the Swift package (for lldb).
bkhouri
deleted the
t/main/fix_echo_command_in_windows_tests_gh8433_rdar148248105
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable all but 3 tests.
Some AsyncProcessTests call to
catandechocommands. Update theexecutable to be called correctly on Windows via the
cmd.exe /ccommand, where the
catequivalent istype, which displays the filecontents.
Also, many tests call a script. We created a batch file, which simply
calls the associated script invoked by python.
Only 3 tests remain skipped.
swift testtp hang.Related to: #8433
rdar://148248105