-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail Macro Expansion if JavaStaticField is used in non-class #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, minor comment
Tests failed, something isn't quite right:
|
Oh my. I'm checking for classdecl, but I think I need to check for extensiondecl. I'll fix this up soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you very much!
Closes #65
This adds support for failing macro expansion if
JavaStaticField
is used in the incorrect context.One thing I was thinking is we can add similar logic for the
JavaStaticMethod
to fail in that context. That will fail in compilation, but it could be nicer to fail expansion vs fail in an implementation detail (of a function not existing on the type)