Do not measure perform performance in CI #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing in Swift CI, run the block to make sure it doesn't hit any assertions because we don't look at performance numbers in CI and CI nodes can have variable performance characteristics if they are not bare-metal. Anywhere else, run XCTest's `measure` function to measure the performance of the block. Fixes swiftlang#939 rdar://145139964
ahoppen
requested review from
allevato,
bnbarham and
shawnhyam
as code owners
allevato
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing in Swift CI, run the block to make sure it doesn't hit any assertions because we don't look at performance numbers in CI and CI nodes can have variable performance characteristics if they are not bare-metal.
Anywhere else, run XCTest's
measurefunction to measure the performance of the block.Fixes #939
rdar://145139964