Remove duplicated dependencies in Package.swift #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
allevato,
bnbarham and
shawnhyam
as code owners
allevato
reviewed
Oct 14, 2024
Package.swift
Outdated
Comment on lines
117
to
118
| .product(name: "SwiftOperators", package: "swift-syntax"), | ||
| .product(name: "SwiftParser", package: "swift-syntax"), |
There was a problem hiding this comment.
Should these two also be moved into swiftSyntaxDependencies?
Not sure how I missed this.
ahoppen
force-pushed
the
duplicate-dependencies
branch
from
bf9ac12
to
a5298f7
Compare
allevato
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how I missed this.