Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add soundness check #824

Merged
merged 7 commits into from
Sep 30, 2024
Merged

[CI] Add soundness check #824

merged 7 commits into from
Sep 30, 2024

Conversation

shahmishal
Copy link
Member

No description provided.

@allevato
Copy link
Member

I was just getting ready to ask about how we could integrate a formatting check. Really happy to see a common workflow for this 😄

The repo definitely won't pass the formatting check today (since we haven't been able to enforce it easily, I didn't want to add more burden to the contribution workflow). I'd be happy to take some time to figure out what my preferred format configuration should be and apply it throughout, though.

@ahoppen @bnbarham If you have logistical reasons that it should match swift-syntax's format configuration, I can live with that, but I'd like to do something even more opinionated here. WDYT?

Comment on lines 15 to 22
api_breakage_check_enabled: true
broken_symlink_check_enabled: true
docs_check_enabled: true
format_check_enabled: true
license_header_check_enabled: false
license_header_check_project_name: "Swift.org"
shell_check_enabled: true
unacceptable_language_check_enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these are enabled in the workflow by default, right? So we could omit all the : true lines, right?

@shahmishal shahmishal merged commit 1e0fd86 into main Sep 30, 2024
13 checks passed
@shahmishal shahmishal deleted the shahmishal/soundness-check branch September 30, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants