-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Custom main and global executors #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Use `any TaskExecutor` instead of `any Executor` for `Task.defaultExecutor`. Rename `ExecutorJobKind` to `ExecutorJob.Kind`. Add `EventableExecutor`; replace `SerialRunLoopExecutor` with `MainExecutor`, then make `MainActor` and `PlatformMainExecutor` use the new protocol.
08df4e3
to
d176b25
Compare
The previous iteration would have required us to make calling the allocation methods a fatal error, and would have meant executors had to check explicitly for the `.task` job kind before using them. Instead, if we add a new `LocalAllocator` type, we can have an `allocator` property that is `nil` if the job doesn't support allocation, and a valid `LocalAllocator` otherwise.
Since the previous pitch, I've added `Clock`-based `enqueue` methods and made a few other changes, notably to the way you actually set custome executors for your program.
Remove `EventableExecutor`; we can come back to that later. Update documentation for `currentExecutor` and add `preferredExecutor` and `currentSchedulableExecutor`. Move the clock-based enqueuing to a separate `SchedulableExecutor` protocol, and provide an efficient way to get it. This means we don't need the `supportsScheduling` property. Back `ClockTraits` with `UInt32`.
We should use typed throws, which will make this work better for Embedded Swift.
/// 1. The custom executor associated with an `Actor` on which we are | ||
/// currently running, or | ||
/// 2. The preferred executor for the currently executing `Task`, or | ||
/// 3. The task executor for the current thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "for the current task" instead of "current thread"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there's a practical difference there; the task executors are tracked using thread local data.
Removed clock conversion functions; we're going to add `enqueue` and `run` functions instead. Updated comments for various items. Mention that we're planning to expose the built-in executor implementations by name.
c76a990
to
90e5d1b
Compare
Add write up of custom executor proposals. There are still some concerns surrounding integration with Dispatch that need working through.