Skip to content

implement parser_fork.c #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gfm
Choose a base branch
from
Open

implement parser_fork.c #79

wants to merge 1 commit into from

Conversation

Lakr233
Copy link

@Lakr233 Lakr233 commented May 25, 2025

This will allow AI powered apps to render more efficiently. I'm new to cmark-gfm, so please review the code carefully. Thanks.

@Kyle-Ye
Copy link

Kyle-Ye commented May 26, 2025

Thank you for the contribution! I'd like to provide some context about this repository and your proposed feature.

Since this is a fork specifically maintained for the Swift toolchain and upstream swift-markdown package support, we generally welcome bug fixes but are more cautious about new feature implementations like parser_fork.c, as they may not align with our specific use case requirements.

A few questions to help evaluate this PR:

  • Upstream consideration: Have you considered submitting this feature to the upstream repository (commonmark/cmark github/cmark-gfm) first? This would ensure broader community review and potentially benefit the entire cmark ecosystem.
  • Swift integration: Do you have a corresponding PR planned for the swift-markdown package that would utilize this new API? Without concrete usage in the Swift ecosystem, it's uncertain whether this feature would be merged into our fork.
  • Use case clarity: Could you elaborate on how this would specifically help "AI powered apps to render more efficiently"? Understanding the concrete use case would help us evaluate the necessity of this feature.

We appreciate your interest in contributing, but want to ensure any additions align with the Swift toolchain's specific needs and have clear integration paths with the broader Swift ecosystem.

cc @QuietMisdreavus

@Lakr233
Copy link
Author

Lakr233 commented May 26, 2025

Well it sounds like pushing to upstream commonmark/cmark would be a better choice at this time. Let me do that first.

@QuietMisdreavus
Copy link

Also keep in mind that swift-cmark is itself a fork of github/cmark-gfm, which has different implementation concerns than commonmark/cmark (specifically the addition of extensions atop the CommonMark standard, like tables and strikethrough). I'm not opposed to adding this kind of API to swift-cmark, but i would also like to know the intended use case. There might still be some global state we inherited from GFM which would mess with this kind of desired deep copy functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants