Skip to content

🍒 [clang][deps] Implement efficient in-process ModuleCache #10471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: swift/release/6.1
Choose a base branch
from

Conversation

jansvoboda11
Copy link

No description provided.

…ocks

🍒 [clang][deps] Implement efficient in-process `ModuleCache`

(cherry picked from commit 42e6d99)
…service

🍒 [clang][deps] Propagate the entire service

Shared state between dependency scanning workers is managed by the dependency scanning service.

Right now, the members are individually threaded through the worker, action, and collector. This makes any change to the service and its members a very laborious process. Moreover, this situation causes frequent merge conflicts in our downstream repo where the service does have some extra members that need to be passed around.

To ease the maintenance burden, this PR starts passing a reference to the entire service.

(cherry picked from commit d2e6662)
(cherry picked from commit de6bfa2)
@jansvoboda11 jansvoboda11 requested a review from a team as a code owner April 10, 2025 17:57
@jansvoboda11
Copy link
Author

@swift-ci please test

@jansvoboda11
Copy link
Author

This was cherry-picked into the corresponding stable branch, but we switched to the release branch and these didn't make the cut.

@jansvoboda11
Copy link
Author

swiftlang/swift#80743
@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants