Code

Merge Webkit checker fixes#10219

Code

Open

rniwa wants to merge 38 commits intoswiftlang:stable/20240723swiftlang/llvm-project:stable/20240723from

rniwa:webkitrniwa/llvm-project:webkitCopy head branch name to clipboard

Commits

Commits on Apr 22, 2025

• [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (#127554)

  Show description for 2cd9739
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  2cd9739

  Copy full SHA for 2cd9739

• [analyzer] Handle structured bindings in alpha.webkit.UncountedCallArgsChecker (#129424)

  Show description for 2570f73
  

  ojhunt

  authored and

  Ryosuke Niwa

  committed
  2570f73

  Copy full SHA for 2570f73

• [alpha.webkit.UncountedCallArgsChecker] Recognize CXXUnresolvedConstructExpr as a safe origin. (#130258)

  Show description for e31b229
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  e31b229

  Copy full SHA for e31b229

• [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit checker for lambda capturing NS or CF types. (#128651)

  Show description for 7314aa9
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  7314aa9

  Copy full SHA for 7314aa9

• [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit checker for unretained member variables and ivars. (#128641)

  Show description for 3985c3f
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  3985c3f

  Copy full SHA for 3985c3f

• [WebKit checkers] Don't treat virtual functions as safe. (#129632)

  Show description for a322a7e
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  a322a7e

  Copy full SHA for a322a7e

• [webkit.UncountedLambdaCapturesChecker] Recognize std::move(protectedThis) (#130925)

  Show description for d3dbb05
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  d3dbb05

  Copy full SHA for d3dbb05

• Add unretained call args checker (#130901)

  Show description for b30d426
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  b30d426

  Copy full SHA for b30d426

• [alpha.webkit.UncountedCallArgsChecker] Treat an explicit construction of Ref from a Ref return value safe. (#130911)

  Show description for 28c78ae
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  28c78ae

  Copy full SHA for 28c78ae

• [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (#128679)

  Show description for 2fae802
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  2fae802

  Copy full SHA for 2fae802

• [alpha.webkit.ForwardDeclChecker] Add a new WebKit checker for forward declarations (#130554)

  Show description for 63ddb4a
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  63ddb4a

  Copy full SHA for 63ddb4a

• [alpha.webkit.UncountedCallArgsChecker] os_log functions should be treated as safe. (#131500)

  Show description for fd04eee
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  fd04eee

  Copy full SHA for fd04eee

• [webkit.NoUncountedMemberChecker] Fix a regression that every class is treated as if it's ref countable. (#131249)

  Show description for 2a385be
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  2a385be

  Copy full SHA for 2a385be

• [webkit.RefCntblBaseVirtualDtor] Add support for NoVirtualDestructorBase. (#132497)

  Show description for 50ad6fb
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  50ad6fb

  Copy full SHA for 50ad6fb

• [WebKit Checkers] Recognize Objective-C and CF pointer conversion functions. (#132784)

  Show description for 41ffb47
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  41ffb47

  Copy full SHA for 41ffb47

• Fix the assertion failure in Analysis/Checkers/WebKit/forward-decl-checker.mm after https://github.com/llvm/llvm-project/pull/132784. (#133341)

  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  1069648

  Copy full SHA for 1069648

• [alpha.webkit.RawPtrRefMemberChecker] The checker doesn't warn Objective-C types in ivars. (#132833)

  Show description for dc2a681
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  dc2a681

  Copy full SHA for dc2a681

• [alpha.webkit.NoUnretainedMemberChecker] Ignore system-header-defined ivar / property of a forward declared type (#133755)

  Show description for ea79d25
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  ea79d25

  Copy full SHA for ea79d25

• [WebKit checkers] Treat Objective-C message send return value as safe (#133605)

  Show description for fd32611
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  fd32611

  Copy full SHA for fd32611

• [alpha.webkit.ForwardDeclChecker] Ignore forward declared struct. (#133804)

  Show description for e250d22
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  e250d22

  Copy full SHA for e250d22

• [alpha.webkit.RetainPtrCtorAdoptChecker] Recognize mutableCopy from literal as +1 (#132350)

  Show description for fcfed41
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  fcfed41

  Copy full SHA for fcfed41

• [alpha.webkit.UnretainedLambdaCapturesChecker] Add the support for protectedSelf (#132518)

  Show description for 81d9f2f
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  81d9f2f

  Copy full SHA for 81d9f2f

• [alpha.webkit.RetainPtrCtorAdoptChecker] Support adopt(cast(copy(~)) (#132316)

  Show description for 9ecfa43
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  9ecfa43

  Copy full SHA for 9ecfa43

• [alpha.webkit.ForwardDeclChecker] Recognize a forward declared template specialization (#134545)

  Show description for 0e333cb
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  0e333cb

  Copy full SHA for 0e333cb

• Remove the redundant check for "WeakPtr" in isSmartPtrClass to fix the issue 135612. (#135629)

  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  abc6a12

  Copy full SHA for abc6a12

• [alpha.webkit.UnretainedCallArgsChecker] Don't emit a warning for RetainPtr::operator= (#135526)

  Show description for 03c2480
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  03c2480

  Copy full SHA for 03c2480

• [alpha.webkit.UnretainedCallArgsChecker] Add the support for RetainPtrArc (#135532)

  Show description for e0eb5fd
  

  rniwa

  authored and

  Ryosuke Niwa

  committed
  e0eb5fd

  Copy full SHA for e0eb5fd

Commits on Apr 23, 2025

• [WebKit checkers] Treat global const variables as safe (#136170)

  Show description for 3803f3b
  rniwa

  committed
  3803f3b

  Copy full SHA for 3803f3b

• [RawPtrRefMemberChecker] Member variable checker should allow T* in smart pointer classes (#136503)

  Show description for daeb3ec
  rniwa

  committed
  daeb3ec

  Copy full SHA for daeb3ec

Commits on Apr 24, 2025

• [alpha.webkit.UncheckedCallArgsChecker] Checker fails to recognize CanMakeCheckedPtrBase (#136500)

  Show description for 5611587
  rniwa

  committed
  5611587

  Copy full SHA for 5611587

Commits on Apr 25, 2025

• [webkit.UncountedLambdaCapturesChecker] Treat a call to lambda function via a variable as safe. (#135688)

  Show description for 41f92b6
  rniwa

  committed
  41f92b6

  Copy full SHA for 41f92b6

Commits on Apr 27, 2025

• [alpha.webkit.RetainPtrCtorAdoptChecker] An assortment of small enhancements (#135329)

  Show description for 04ec1fb
  rniwa

  committed
  04ec1fb

  Copy full SHA for 04ec1fb

• [alpha.webkit.RetainPtrCtorAdoptChecker] Check nullity before calling IgnoreParenCasts. (#137556)

  rniwa

  committed
  e8e99e6

  Copy full SHA for e8e99e6

Commits on May 1, 2025

• [RawPtrRefMemberChecker] Make RawPtrRefMemberChecker consistent with other checkers (#137559)

  Show description for a8a2a22
  rniwa

  committed
  a8a2a22

  Copy full SHA for a8a2a22

• [WebKit checkers] Treat std::bit_cast as a pointer conversion (#137476)

  Show description for e76e829
  rniwa

  committed
  e76e829

  Copy full SHA for e76e829

Commits on May 7, 2025

• [webkit.UncountedLambdaCapturesChecker] Treat a copy capture of a CheckedPtr object as safe (#138068)

  Show description for d236bc8
  rniwa

  committed
  d236bc8

  Copy full SHA for d236bc8

Commits on May 10, 2025

• [RawPtrRefMemberChecker] Add the support for union and pointers to unsafe pointers. (#138042)

  Show description for bef9d8b
  rniwa

  committed
  bef9d8b

  Copy full SHA for bef9d8b

• [webkit.UncountedLambdaCapturesChecker] Treat every argument of std::ranges functions as noescape. (#138995)

  Show description for 73fdce8
  rniwa

  committed
  73fdce8

  Copy full SHA for 73fdce8