Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb][lldb-dap][test] Skip launch test on Windows again #10053

Conversation

weliveindetail
Copy link
Member

#9770 enabled a bunch of lldb-dap tests on Windows. Apparently, TestDAP_launch.test_environment_with_object is still flaky. Let's disable it in order to avoid sporadic failures of pre-merge tests.

@weliveindetail weliveindetail requested a review from a team as a code owner February 18, 2025 13:03
@weliveindetail
Copy link
Member Author

@swift-ci please test

@weliveindetail
Copy link
Member Author

We should get better monitoring for such sporadic failures. I am looking through PR test failures form time to time, but that's not sufficient. LLDB tests should run on mainline bots. I did submit a request for that a few weeks ago: swiftlang/swift#79020

@weliveindetail
Copy link
Member Author

The failure was observed in this PR test: https://ci-external.swift.org/job/swift-PR-windows/36604/
Attaching the test log here for future reference: TestDAP_launch.log

@adrian-prantl adrian-prantl merged commit d7de9bd into swiftlang:stable/20240723 Feb 18, 2025
2 of 3 checks passed
@weliveindetail weliveindetail deleted the windows-lldb-test-reskip-dap-launch branch February 19, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants