Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce time spent logging EventLoop description in HTTP1ClientChannelHandler #772

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Reduce time spent logging EventLoop description in HTTP1ClientChannelHandler #772

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
030dec3
Store the EventLoop description property upon initializing instead of…
aryan-25 Sep 17, 2024
d32fa8b
Use string interpolation to initialize Logger.MetadataValue
aryan-25 Sep 19, 2024
f0829f6
Merge branch 'main' into reduce-time-logging-el-description
aryan-25 Sep 19, 2024
fcbfd3b
Merge branch 'main' into reduce-time-logging-el-description
Lukasa Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/AsyncHTTPClient/ConnectionPool/HTTP1/HTTP1ClientChannelHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
if let newRequest = self.request {
var requestLogger = newRequest.logger
requestLogger[metadataKey: "ahc-connection-id"] = self.connectionIdLoggerMetadata
requestLogger[metadataKey: "ahc-el"] = "\(self.eventLoop)"
requestLogger[metadataKey: "ahc-el"] = self.eventLoopDescription
self.logger = requestLogger

if let idleReadTimeout = newRequest.requestOptions.idleReadTimeout {
Expand Down Expand Up @@ -72,11 +72,13 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
private let backgroundLogger: Logger
private var logger: Logger
private let eventLoop: EventLoop
private let eventLoopDescription: Logger.MetadataValue
private let connectionIdLoggerMetadata: Logger.MetadataValue

var onConnectionIdle: () -> Void = {}
init(eventLoop: EventLoop, backgroundLogger: Logger, connectionIdLoggerMetadata: Logger.MetadataValue) {
self.eventLoop = eventLoop
self.eventLoopDescription = "\(eventLoop.description)"
self.backgroundLogger = backgroundLogger
self.logger = backgroundLogger
self.connectionIdLoggerMetadata = connectionIdLoggerMetadata
Expand Down