Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rust lints #1424

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix rust lints #1424

merged 1 commit into from
Aug 16, 2024

Conversation

pcrumley
Copy link
Contributor

Description

@swift-nav/devinfra

A simple whitespace fix to get rust lints passing

API compatibility

Does this change introduce a API compatibility risk?

No

API compatibility plan

N/A

JIRA Reference

N/A

@pcrumley pcrumley requested review from a team and notoriaga as code owners August 15, 2024 22:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed for 'libsbp-c'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

RReichert
RReichert approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@RReichert RReichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have assumed that by running make gen-all I would have given me this result if I were to have checked out the master branch. Did you have to run something separate outside of what make offers to get it to format for you?

javascript/sbp/observation.js Show resolved Hide resolved
@pcrumley pcrumley merged commit 7cd481b into master Aug 16, 2024
34 of 36 checks passed
@pcrumley pcrumley deleted the pcrumley/fix-new-lints branch August 16, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljbade ljbade ljbade approved these changes

@RReichert RReichert RReichert approved these changes

@sokhealy sokhealy sokhealy approved these changes

@notoriaga notoriaga Awaiting requested review from notoriaga notoriaga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcrumley @ljbade @RReichert @sokhealy