Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AES-CMAC 128 Message [CLDAPPS-1503] #1423

Merged
merged 4 commits into from
Aug 15, 2024
Merged

AES-CMAC 128 Message [CLDAPPS-1503] #1423

merged 4 commits into from
Aug 15, 2024

Conversation

RReichert
Copy link
Contributor

@RReichert RReichert commented Aug 14, 2024 •
edited
Loading

Description

Adding a new "AES CMAC signature" message.

image

API compatibility

No, this is a new message.

API compatibility plan

N/A

JIRA Reference

https://swift-nav.atlassian.net/browse/CLDAPPS-1503

@RReichert RReichert changed the title AES-CMAC messageg AES-CMAC 128 Message Aug 14, 2024
@RReichert RReichert force-pushed the rodrigor/CLDAPPS-1503-new-signature-message-AES-CMAC branch from 55ff859 to 540b2a2 Compare August 14, 2024 06:51
@RReichert RReichert changed the title AES-CMAC 128 Message AES-CMAC 128 Message [/CLDAPPS-1503] Aug 14, 2024
@RReichert RReichert changed the title AES-CMAC 128 Message [/CLDAPPS-1503] AES-CMAC 128 Message [CLDAPPS-1503] Aug 14, 2024
@RReichert RReichert force-pushed the rodrigor/CLDAPPS-1503-new-signature-message-AES-CMAC branch from a234223 to 186f070 Compare August 14, 2024 07:12
@RReichert RReichert marked this pull request as ready for review August 15, 2024 03:11
@RReichert RReichert requested review from a team, notoriaga and pcrumley as code owners August 15, 2024 03:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed for 'libsbp-c'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

notoriaga
notoriaga approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@notoriaga notoriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take a look at the rust stuff tomorrow

@RReichert RReichert enabled auto-merge (squash) August 15, 2024 05:30
sokhealy
sokhealy approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@sokhealy sokhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

pcrumley
pcrumley approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@pcrumley pcrumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RReichert RReichert merged commit 9559cb7 into master Aug 15, 2024
31 of 34 checks passed
@RReichert RReichert deleted the rodrigor/CLDAPPS-1503-new-signature-message-AES-CMAC branch August 15, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokhealy sokhealy sokhealy approved these changes

@pcrumley pcrumley pcrumley approved these changes

@notoriaga notoriaga notoriaga approved these changes

@ljbade ljbade ljbade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RReichert @ljbade @notoriaga @pcrumley @sokhealy