Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTE-6][IOTE-326] Add weeks behavior flag to MSG_GNSS_TIME_OFFSET #1405

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

jakalm
Copy link
Contributor

@jakalm jakalm commented Mar 15, 2024

Description

@swift-nav/devinfra

Adding a new flag to the reserved flags field in the MSG_GNSS_TIME_OFFSET message to flag if the timestamp is affected by local timestamp rollover or not. For more information, see https://swift-nav.atlassian.net/wiki/spaces/~622a65696a4c4c0070b2567a/pages/3060662918/Amazon+INS+timestamp+issue+way+forward#Conclusion-and-decision.

API compatibility

Does this change introduce a API compatibility risk?

No, this has been a reserved field so should not be incompatible with current implementations of the protocol.

API compatibility plan

JIRA Reference

https://swift-nav.atlassian.net/browse/IOTE-325

@jakalm jakalm self-assigned this Mar 15, 2024
@jakalm jakalm force-pushed the jakob/iote-6/amazon-timestamp branch from eec10de to 1a604cd Compare March 15, 2024 10:27
@jakalm jakalm changed the title [IOTE-6][IOTE-325] Status flags for MSG_GNSS_TIME_OFFSET is no longer reserved [IOTE-6][IOTE-326] Add local timestamp week rollover flag Mar 15, 2024
@jakalm jakalm force-pushed the jakob/iote-6/amazon-timestamp branch 8 times, most recently from 6118f99 to 0af9579 Compare March 16, 2024 10:07
@jakalm jakalm force-pushed the jakob/iote-6/amazon-timestamp branch from 0af9579 to 5d2e906 Compare March 16, 2024 10:18
@jakalm jakalm changed the title [IOTE-6][IOTE-326] Add local timestamp week rollover flag [IOTE-6][IOTE-326] Add weeks behavior flag to MSG_GNSS_TIME_OFFSET Mar 16, 2024
@jakalm jakalm marked this pull request as ready for review March 16, 2024 12:39
Copy link
Contributor

@sokhealy sokhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apologies for my confusion.

@jakalm jakalm requested a review from ljbade March 19, 2024 07:24
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed for 'libsbp-c'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jakalm jakalm merged commit 3f933a2 into master Mar 28, 2024
36 checks passed
@jakalm jakalm deleted the jakob/iote-6/amazon-timestamp branch March 28, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants