Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse error falls back to Invalid #1312

Merged
merged 43 commits into from
Jul 18, 2023
Merged

Parse error falls back to Invalid #1312

merged 43 commits into from
Jul 18, 2023

Commits on Mar 29, 2023

  1. parse error falls back to unknown

    @adrian-kong
    adrian-kong committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    fa75ba1 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. something like this instead?

    @adrian-kong
    adrian-kong committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c17a922 View commit details
    Browse the repository at this point in the history

  2. clippy

    @adrian-kong
    adrian-kong committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c2213ce View commit details
    Browse the repository at this point in the history

  3. clippy

    @adrian-kong
    adrian-kong committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    092d4bc View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Merge remote-tracking branch 'origin/master' into adrian/unknown-fall… 

    …back
    Jason Mobarak committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7613b89 View commit details
    Browse the repository at this point in the history

  2. Handle missing data

    Jason Mobarak committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5fe6616 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Merge branch 'master' into adrian/unknown-fallback

    @pcrumley
    pcrumley committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    893a6a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. fix tests (#1339) 

    The minimum set of changes to get the parse unknown falllback tests to
pass, but I'm not 100% sure it solves the desired problem
    @pcrumley
    pcrumley committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    465a6a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Merge branch 'master' into adrian/unknown-fallback

    @pcrumley
    pcrumley committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2bc3417 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'adrian/unknown-fallback' of github.com:swift-nav/libsbp… 

    … into adrian/unknown-fallback
    @pcrumley
    pcrumley committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d4b9784 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. wip

    @pcrumley
    pcrumley committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    5611749 View commit details
    Browse the repository at this point in the history

  2. refactor parsing, add new error type with a sender ID and a msg_type ID

    @pcrumley
    pcrumley committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b05b267 View commit details
    Browse the repository at this point in the history

  3. unknown fallback

    @pcrumley
    pcrumley committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    443b1a6 View commit details
    Browse the repository at this point in the history

  4. add some docstrings where methods can panic

    @pcrumley
    pcrumley committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    383870c View commit details
    Browse the repository at this point in the history

  5. fmt

    @pcrumley
    pcrumley committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0402244 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. move diffs to generator. Mistakenly hand-edited auto-genarated code

    @pcrumley
    pcrumley committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    d2ee464 View commit details
    Browse the repository at this point in the history

  2. fix lint

    @pcrumley
    pcrumley committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    699036f View commit details
    Browse the repository at this point in the history

  3. add invalid msg type

    @pcrumley
    pcrumley committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ef792bc View commit details
    Browse the repository at this point in the history

  4. working on finishing this up

    @pcrumley
    pcrumley committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    688c17d View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. MVP of feature

    @pcrumley
    pcrumley committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    602811f View commit details
    Browse the repository at this point in the history

  2. fix clippy

    @pcrumley
    pcrumley committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    0a81484 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into adrian/unknown-fallback

    @pcrumley
    pcrumley committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    c1e4cc9 View commit details
    Browse the repository at this point in the history

  4. update invalid message in code documentaiton

    @pcrumley
    pcrumley committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    e89b957 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. fix pointer to gen file

    @pcrumley
    pcrumley committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b1e04b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Update rust/sbp/src/messages/invalid.rs 

    Co-authored-by: Jason Mobarak <[email protected]>
    @pcrumley
    pcrumley and Jason Mobarak committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    1250509 View commit details
    Browse the repository at this point in the history

  2. Update rust/sbp/src/messages/invalid.rs 

    Co-authored-by: Jason Mobarak <[email protected]>
    @pcrumley
    pcrumley and Jason Mobarak committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    fa8a272 View commit details
    Browse the repository at this point in the history

  3. Update rust/sbp2json/src/bin/json2json.rs 

    Co-authored-by: Jason Mobarak <[email protected]>
    @pcrumley
    pcrumley and Jason Mobarak committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    3b73f6e View commit details
    Browse the repository at this point in the history

  4. Update rust/sbp2json/src/bin/sbp2json.rs 

    Co-authored-by: Jason Mobarak <[email protected]>
    @pcrumley
    pcrumley and Jason Mobarak committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    509ebbf View commit details
    Browse the repository at this point in the history

  5. Update rust/sbp2json/src/bin/json2sbp.rs 

    Co-authored-by: Jason Mobarak <[email protected]>
    @pcrumley
    pcrumley and Jason Mobarak committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    09cc839 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into adrian/unknown-fallback

    @pcrumley
    pcrumley committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    d051faf View commit details
    Browse the repository at this point in the history

  7. Merge branch 'adrian/unknown-fallback' of github.com:swift-nav/libsbp… 

    … into adrian/unknown-fallback
    @pcrumley
    pcrumley committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    58e9098 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. wip, address pr feedback

    @pcrumley
    pcrumley committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bfbde5f View commit details
    Browse the repository at this point in the history

  2. fix clippy

    @pcrumley
    pcrumley committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    c7d3da5 View commit details
    Browse the repository at this point in the history

  3. maybe fix build

    @pcrumley
    pcrumley committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    e5125b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. address feedback

    @pcrumley
    pcrumley committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e50072e View commit details
    Browse the repository at this point in the history

  2. forgot to add generator files

    @pcrumley
    pcrumley committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9c8a412 View commit details
    Browse the repository at this point in the history

  3. remove let else

    @pcrumley
    pcrumley committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    96ea494 View commit details
    Browse the repository at this point in the history

  4. do some work to support roundtrip, still wip

    @pcrumley
    pcrumley committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c979177 View commit details
    Browse the repository at this point in the history

  5. remove crc from msg

    @pcrumley
    pcrumley committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5698712 View commit details
    Browse the repository at this point in the history

  6. still deserialize crc if possible

    @pcrumley
    pcrumley committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9a8bac0 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. add unit tests for recovering from parsing errors of sbp (#1347) 

    This PR adds a unit test showing that parsing errors fallsback to an
invalid message.

Seeing this unit test makes it clear why some of the questions
@silverjam was having about invoking this on certain inputs causes it to
pass and others cause it to fail. Additionally the round-tripping on
arbitrary bytes is not possible yet because both the iter_frame &
iter_messages will only return a message if there is something that
starts with the prelude byte, and it returns the bytes that exist
between that prelude and HEADER_LEN, whatever the length of the payload
is on byte 5 + the CRC_LEN. This means that if there are extra bytes
sent in the stream for aliasing for instance, the framer ignores those
bytes, and they are never even tried to be parsed.

@silverjam gave two examples that do not throw an error as the unknown
fallback is currently implemented. One of those has been added as a unit
test here. But the main takeaway is the invalid-fallback as currently
written only works on messages that are properly framed but perhaps
wrongly labeled or with a CRC error.
    @pcrumley
    pcrumley committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c000e0a View commit details
    Browse the repository at this point in the history

  2. Require structs that impl SbpMessage also impl WireFormat and Clone

    @pcrumley
    pcrumley committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8f6aebf View commit details
    Browse the repository at this point in the history

  3. bump benchmark thresholds

    @silverjam @pcrumley
    silverjam authored and pcrumley committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    0d97927 View commit details
    Browse the repository at this point in the history