Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orion cmake configuration fails when CMAKE_C_COMPILED_ID is not set [OI-1869] #176

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

armallen
Copy link
Contributor

@armallen armallen commented Jul 31, 2024

Jira Ticket

https://swift-nav.atlassian.net/browse/OI-1869

Bug description

orion build fails with

CMake Error at third_party/orion-engine/third_party/auk/cmake/swift_nav/LanguageStandards.cmake:63 (if):
  if given arguments:

    "STREQUAL" "IAR"

  Unknown arguments specified
Call Stack (most recent call first):
  third_party/orion-engine/third_party/auk/cmake/swift_nav/SwiftTargets.cmake:351 (swift_set_language_standards)
  third_party/orion-engine/third_party/auk/cmake/swift_nav/SwiftTargets.cmake:373 (swift_add_target)
  proto/CMakeLists.txt:29 (swift_add_library)

CMake syntax allows using the variable without ${} to simultaneously check if variable is defined, and variable content.

Testing

Updated third_party/orion-engine/third_party/auk/cmake/swift_nav/LanguageStandards.cmake locally with the fix, CMake config runs correctly.

@armallen armallen requested a review from a team as a code owner July 31, 2024 12:51
Copy link

sonarcloud bot commented Jul 31, 2024

@armallen armallen changed the title orion cmake configuration fail [OI-1869] orion cmake configuration fails when CMAKE_C_COMPILED_ID is not set [OI-1869] Jul 31, 2024
@RReichert RReichert merged commit 5b65c03 into master Jul 31, 2024
2 checks passed
@RReichert RReichert deleted the armallen/c-compiler-id-fix branch July 31, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants