Handle new suitesparse version #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlttiJokinen
changed the title
jbangelo
reviewed
Jan 11, 2024
| @@ -18,13 +18,13 @@ endif() | |||
| find_path(suitesparse_cholmod_INCLUDE_DIR | |||
| NAMES cholmod.h | |||
| HINTS ${SUITESPARSE_DIRS} | |||
| PATH_SUFFIXES include | |||
There was a problem hiding this comment.
I think we need to keep the include suffix for the Linux installs and older versions on Mac
There was a problem hiding this comment.
It seems that I made mistake, it should have been include and not suitesparse
|
|
@ljbade I can see that your approval is needed, because must be someone from dev infra |
|
Has this now been tested on both Linux and Mac? |
|
@ljbade Yes, it has been compiled as part of Albatross pipeline swift-nav/albatross#473 (comment) |
ljbade
approved these changes
Jan 12, 2024
AlttiJokinen
added a commit
to swift-nav/albatross
that referenced
this pull request
Jan 24, 2024
https://swift-nav.atlassian.net/browse/OC-729 Handle new Suitesparse version and dix Apple Clang compiling Submodule links need to be corrected for Cmake and eigen after these PRs are merged swift-nav/cmake#171 swift-nav/eigen#4
jungleraptor
added a commit
that referenced
this pull request
Apr 3, 2024
This reverts commit 436d339.
jungleraptor
added a commit
that referenced
this pull request
Apr 3, 2024
This reverts commit 7c94a80.
woodfell
added a commit
to swift-nav/libsbp
that referenced
this pull request
Apr 29, 2024
Automated PR by Jenkins. If CI has passed successfully, merge away! **cmake** f5113f7d -> 117b3f73 - 117b3f73 : enable c++20 (swift-nav/cmake#173) - 436d339a : Handle new suitesparse version (swift-nav/cmake#171) This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/17095/. Co-authored-by: Matt Woodward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://swift-nav.atlassian.net/browse/OC-729
Handle directory structure of new Suitesparse version