Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CODEOWNERS #161

Merged
merged 1 commit into from
Jul 27, 2023
Merged

add CODEOWNERS #161

merged 1 commit into from
Jul 27, 2023

Conversation

jungleraptor
Copy link
Contributor

Enables developer infrastructure to be aware of any development going on in the cmake repo.

Particularly we want to avoid new features being developed for cmake that are not accounted for in the bazel system.

Enables developer infrastructure to be aware of any development going
on in the cmake repo.

Particularly we want to avoid new features being developed for
cmake that are not accounted for in the bazel system.
@jungleraptor
Copy link
Contributor Author

cc @silverjam do we need to edit the project settings so that it requires dev-infra for reviews in this repo?

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@jungleraptor
Copy link
Contributor Author

Yes please

I don't have permissions to view/edit the settings in this repo.

I thought just adding the CODEOWNERS file would make the reviews required but it doesn't look like that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants