Repair this program for 2015. #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses that is. This was demonstrated to me by my rewrite in python: https://github.com/kousu/omapboot
|
I was wrong. The reopen is unimportant, and I've removed that part. |
This reverts commit a8d415b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #8, I've committed @dmitry-pervushin's fix to the asm code (which I would have had no idea how to fix, so thanks Dimitry), and I've also dug deep with packet sniffers and solved why this version wasn't booting my phone and @wkpark's was: this version was not giving the 2nd stage time to orient itself. The 2nd stage is running on a slower machine than my (and probably your) host, and can be swamped out and confused if you talk to it too quickly; also the USB endpoint should be reopened to notify the 2nd stage that it has someone to talk to; with the
sleep()but without the reopen, mostly the boot goes properly, but sometimes it fails. Adding the reopen makes it so far 100% reliable for me. Plus TI does it too.I hae not edited the Makefile in this patch, because I do not know if the
arm-eabi-->arm-none-eabi-change was archlinux specific or broader.