Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH actions config file #909

Closed
wants to merge 1 commit into from
Closed

Update GH actions config file #909

wants to merge 1 commit into from

Conversation

skanwal
Copy link
Contributor

@skanwal skanwal commented Jan 7, 2025

One of our recent PRs failed with the GitHub action error.
https://github.com/swcarpentry/r-novice-gapminder/actions/runs/12642590727/job/35230110313

Think that can be addressed by modifying the workflow configuration to ensure that artifact names are unique.
I have appended a run id to artifact names.

Copy link

github-actions bot commented Jan 7, 2025

ℹ️ Modified Workflows

This pull request contains modified workflow files and no preview will be created.

Workflow files modified:

  • .github/workflows/pr-receive.yaml

If this is not from a trusted source, please inspect the changes for any malicious content.

Copy link
Contributor

@matthieu-bruneaux matthieu-bruneaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @skanwal! I am not that experienced with GitHub actions myself, but your edits look good to me.

@naupaka
Copy link
Member

naupaka commented Jan 7, 2025

I think this might be the sort of thing that we want to get fixed upstream, or we risk a merge conflict when new changes are made to the infrastructure. This is the sort of thing that's above my pay grade, but maybe @froggleston or @tobyhodges knows better?

@tobyhodges
Copy link
Member

I do not really understand what went wrong with that workflow, but it looks like the error was spurious as I have just re-run it and everything worked fine this time. I think this PR can be safely closed.

As @naupaka suggests, we keep these workflow files updated centrally. PRs to fix/improve the workflows are welcome at https://github.com/carpentries/actions where necessary, but it looks like this one was a gremlin in GItHub's systems...

@naupaka
Copy link
Member

naupaka commented Jan 7, 2025

Closing because this should be fixed upstream and because upon re-running, checks passed. Thanks @skanwal for the sleuthing!

@naupaka naupaka closed this Jan 7, 2025
@skanwal
Copy link
Contributor Author

skanwal commented Jan 8, 2025

Thanks. Interesting, rerunning the test failed for me yesterday and that's when I started investigating it.
Anyways, all good if that has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants