feat: make error format configurable

[mertcanaltin]

• Added ErrorFormatConfig enum to allow configuration of the ErrorFormat used in the minify_sync function.
• Updated minify_sync to accept an optional error_format parameter, which can be set to "normal", "json", or "color".
• The error_format parameter defaults to ErrorFormat::Normal if not provided.
• This change resolves the TODO for making the ErrorFormat configurable, providing greater flexibility in error reporting formats.

can be used in the typeScript field : const result = minify_sync(codeBuffer, optsBuffer, "json");

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5ff4634

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Mert Can Altin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[codspeed-hq]

CodSpeed Performance Report

Merging #9441 will degrade performances by 6.34%

_{Comparing mertcanaltin:dev-001 (7c3980b) with main (50d70d3)}

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 175 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	mertcanaltin:dev-001	Change
❌	es/full/bugs-1	553.4 µs	590.9 µs	-6.34%
⚡	es/full/codegen/es2015	290.1 µs	275.8 µs	+5.21%
⚡	serialization of serde	2.9 µs	2.8 µs	+4.17%

[kdy1]

Build in CI failed

[kdy1]

cc @kwonoj Do you have any idea about this?

[kdy1]

Why is this option in binding?

[mertcanaltin]

The ErrorFormatConfig was introduced to provide flexibility in formatting error outputs, allowing different representations (e.g., JSON) depending on the user's needs. It was included here to streamline error handling directly within the minification process

[kdy1]

I mean, why is it stored in bindings/*? I think it's a quite general option and I believe swc_error_reporters is the better place to store this type.

[mertcanaltin]

now I understand better thank you I will make an update

[kdy1]

Also, why is this an additional parameter, instead of additional field?

[mertcanaltin]

I think reasoning behind using an additional parameter instead of a field was to maintain the separation of concerns. By keeping ErrorFormatConfig as a separate argument, it avoids bloating the existing options structure and allows for easier future extensions or modifications

[kwonoj]

Do you have any idea about this?

Sorry, checking in late. Mind elaborate what you have in mind? the config option itself?

[kdy1]

Yeap, and it being an additional parameter instead of a field.

[kwonoj]

Yes, curious if there's a reason it have to be a 3rd arg instead of extending existing option.

[mertcanaltin]

Yes, curious if there's a reason it have to be a 3rd arg instead of extending existing option.

decision to introduce it as a third argument rather than extending the existing options was to avoid coupling the error formatting configuration with the core minify options. This modular approach allows users to control error output separately, which can be more intuitive and flexible

[mertcanaltin]

thank you for your suggestions I sent a commit

[mertcanaltin]

I wonder if you have a suggestion about this error @kdy1

I think it's because it's in string type

error[E0308]: mismatched types
  --> binding_core_node/src/minify.rs:85:38
   |
85 |     let task = MinifyTask { c, code, options };
   |                                      ^^^^^^^ expected `String`, found `JsMinifyOptions`

[kdy1]

Please patch

swc/bindings/binding_core_node/src/minify.rs

Lines 62 to 66 in b0b5e36

	try_with(self.c.cm.clone(), false, ErrorFormat::Normal, |handler| {
	let fm = input.to_file(self.c.cm.clone());
	self.c.minify(fm, handler, &options)
	})

too