refactor(swc/plugin_runner): refactor transform executor (#5060: Part 4) #5147
+171
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
force-pushed
the
refactor-trasnform-executor
branch
from
a44952d to
d942505
Compare
kwonoj
force-pushed
the
refactor-trasnform-executor
branch
from
d942505 to
8fdb287
Compare
kdy1
reviewed
Jul 8, 2022
kdy1
approved these changes
Jul 8, 2022
swc-bot
reviewed
Jul 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To introduce another call to plugin binary for schema version invalidation, PR refactors execution entrypoint bit to allow
TransformExecutorcan be used for subsequent calls.Also amends internal swc_plugin_macro's ident name to clarify
transformplugin. This'll probably break existing plugins and requires to bump up dependencies on each plugin's end. Something we should do before out of experimental flag.BREAKING CHANGE:
Related issue (if exists):
#5060