Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GHC2021 extensions default #520

Merged
merged 9 commits into from
Jul 1, 2022
Merged

Make GHC2021 extensions default #520

merged 9 commits into from
Jul 1, 2022

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Jun 30, 2022

@xsebek
Copy link
Member Author

xsebek commented Jun 30, 2022

This will likely cause merge conflicts, so we could consider leaving this as the last to merge 😉

@xsebek
Copy link
Member Author

xsebek commented Jun 30, 2022

I wonder why Fourmolu failed in restyled? 🤔 It should find the extension in the cabal file just fine.

@byorgey
Copy link
Member

byorgey commented Jun 30, 2022

No opinion on whether we should wait to merge this. We are going to have merge conflicts one way or another. I guess you mean if we wait to merge this, then maybe we will just be able to fix a bunch of merge conflicts here at once, instead of having to fix merge conflicts for every other pending PR.

On the other hand there are always going to be more PRs... 😄

@byorgey
Copy link
Member

byorgey commented Jun 30, 2022

I wonder why Fourmolu failed in restyled? It should find the extension in the cabal file just fine.

Indeed, that is strange. https://hackage.haskell.org/package/fourmolu-0.7.0.1#language-extensions-dependencies-and-fixities does seem to imply this should work.

@xsebek
Copy link
Member Author

xsebek commented Jun 30, 2022

Yes, it does, if you provide the --cabal-default-extensions flag. 😒

I am looking for a way to enable that in CI...

@byorgey
Copy link
Member

byorgey commented Jun 30, 2022

Can we put it in fourmolu.yaml?

@xsebek
Copy link
Member Author

xsebek commented Jun 30, 2022

No, but we should be able to add it to restyled.

@xsebek
Copy link
Member Author

xsebek commented Jun 30, 2022

Hey @TristanCacqueray, would you happen to know how to fix restyled fourmolu?

I tried something in #521, but I could not get it to work with the 0.3.0.0 version. 😞

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Jul 1, 2022
@mergify mergify bot merged commit 8652440 into main Jul 1, 2022
@mergify mergify bot deleted the ghc2021 branch July 1, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using GHC2021 extensions by default
4 participants