Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create copyright.html #629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create copyright.html #629

wants to merge 1 commit into from

Conversation

neeru24
Copy link
Contributor

@neeru24 neeru24 commented Oct 21, 2024

Add Copyright Page

Description

This pull request introduces a fully responsive Copyright page for the Collect Your Gaming Tools website. The following features and improvements have been implemented:

Features and Improvements

  • Navbar: Added a centered navigation bar with links to "Home," "About," and a "Switch Theme" button.
  • Dark Theme: Implemented a dark theme for the Copyright page, ensuring a consistent user experience across the site.
  • Responsive Design: Utilized flexbox to create a responsive layout that stacks navbar items vertically on smaller screens.
  • Hover Effects: Added hover effects to buttons and sections for improved user interaction.
  • Copyright Sections: Structured the page with clear sections outlining copyright notice, content ownership, trademark information, and contact details.
  • Footer: Included a footer stating copyright information, ensuring compliance and professionalism.

Additional Changes

  • Updated CSS to enhance styling for both light and dark themes.
  • Ensured all interactive elements are easily accessible and visually appealing.

Testing

The Copyright page has been tested across various devices and screen sizes to ensure proper responsiveness and usability.


Note: Please review the code and assign me LEVEL 3 for this @swaraj-das
fixes: #576

image
image
image
image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @neeru24! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:36am

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 25b5be7
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/671620826712dd0008624c48
😎 Deploy Preview https://deploy-preview-629--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AnitSarkar123
Copy link
Collaborator

AnitSarkar123 commented Oct 21, 2024

Link it with the main page

@neeru24
Copy link
Contributor Author

neeru24 commented Oct 21, 2024

Link it with the main page

Check. It. Please #608

@AnitSarkar123
Copy link
Collaborator

Link it with the main page

Check. It. Please #608

@swaraj-das please say something to her because I don't have any words to say her.

@swaraj-das
Copy link
Owner

@neeru24 "Pull requests that only partially address an issue are not acceptable. We will only consider merging your PR if it fully resolves the issue. Submitting incomplete solutions in parts solely to gain extra points on the leaderboard is prohibited and will not be tolerated."

@neeru24
Copy link
Contributor Author

neeru24 commented Oct 22, 2024

@neeru24 "Pull requests that only partially address an issue are not acceptable. We will only consider merging your PR if it fully resolves the issue. Submitting incomplete solutions in parts solely to gain extra points on the leaderboard is prohibited and will not be tolerated."

I agree but I was assigned with the issues and I did what I mentioned in the issue like there was no page for copyright and I created that and I've changed the main file too that links it with that.. So May I please know where the issue is partially addressed?

@swaraj-das
Copy link
Owner

@swaraj-das please say something to her because I don't have any words to say her.

I'm shocked to see PRs submitted separately for such closely related tasks like adding links in HTML and creating the actual pages. I previously noticed someone else doing something similar. This behavior is not acceptable, and if it continues, I will have no choice but to report it to the event organizers.

@swaraj-das
Copy link
Owner

@neeru24 "Pull requests that only partially address an issue are not acceptable. We will only consider merging your PR if it fully resolves the issue. Submitting incomplete solutions in parts solely to gain extra points on the leaderboard is prohibited and will not be tolerated."

I agree but I was assigned with the issues and I did what I mentioned in the issue like there was no page for copyright and I created that and I've changed the main file too that links it with that.. So May I please know where the issue is partially addressed?

Sync your fork, and you'll find a 'policies' folder. Add all the policy HTML files there and link them in the index.

@neeru24
Copy link
Contributor Author

neeru24 commented Oct 22, 2024

@neeru24 "Pull requests that only partially address an issue are not acceptable. We will only consider merging your PR if it fully resolves the issue. Submitting incomplete solutions in parts solely to gain extra points on the leaderboard is prohibited and will not be tolerated."

I agree but I was assigned with the issues and I did what I mentioned in the issue like there was no page for copyright and I created that and I've changed the main file too that links it with that.. So May I please know where the issue is partially addressed?

Sync your fork, and you'll find a 'policies' folder. Add all the policy HTML files there and link them in the index.

Okay, Thank you for helping out and please tell us before making any comment like what we are doing wrong. Many of the contributors are new to open source, so it would be better if you could guide us and we'll work on that too.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of Copyright Page
3 participants