Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter logo Update #114

Merged
merged 9 commits into from
Oct 7, 2024

Conversation

rajdeepchakraborty-rc
Copy link
Contributor

@rajdeepchakraborty-rc rajdeepchakraborty-rc commented Oct 4, 2024

Pull Request Format

Updated X(Twitter) Logo added

Issue #105 : Update X[Twitter] Logo. [SOLVED]

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to replace the X (Twitter) logo with the updated version to eliminate any ambiguity for users.

Screenshots / Videos (if applicable)

Before:
image

  • The old Twitter logo was being used.

After:
image

  • Updated with the new logo (along with the animation)

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

I had to face the challenge of the newly added X(Twitter) Icon not having the hover zoom animation. Thus, had to change the CSS a bit to solve the issue.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 9:13am

@rajdeepchakraborty-rc
Copy link
Contributor Author

@swaraj-das Please add the following labels:

  1. Issue Update X[Twitter] Logo. #105 - level label.
  2. PR Twitter logo Update #114 - gssoc-ext, hacktoberfest-accepted and level.
    I hope the following feature change helps your website reach more people.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@swaraj-das Please review this PR too. You have reviewed my other PR, but this one is pending. Also reminder to add level tag in the issue #105.

@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 6, 2024

@AnitSarkar123, Please review this PR. Also look into the issue that occurred in PR #127. Due to wrong issue of labels, the PR is not being reflected on the GSSoC leaderboard. I have raised 2 issues on this repository and the later one has been merged, but this one is yet pending.

@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 6, 2024

@swaraj-das Please review this PR and give a label in issue #105

@swaraj-das
Copy link
Owner

@rajdeepchakraborty-rc Merge conflicts. Please resolve it.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@swaraj-das Ok

@rajdeepchakraborty-rc
Copy link
Contributor Author

Also please assign a level to the issue #105

@rajdeepchakraborty-rc
Copy link
Contributor Author

@swaraj-das I have synced my branch and resolved the merge conflict. Please review it.

@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 7, 2024

Ok I noticed that the zoom effect on hover has been removed. Please wait a while. I will add that

@rajdeepchakraborty-rc
Copy link
Contributor Author

Apart from adding the updated X[Twitter] logo, I have also added the following hover animation on the Social Icons:

Hover.Animation.on.Social.Icons.mp4

Please review the PR at your earliest.

@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 7, 2024

@swaraj-das Also a friendly reminder from the GSSoC community announcements:
image

Please issue the correct tags. Also issue level tag in the corresponding issue #105. Would appreciate a level2 tag since I have updated the code and also added an extra hover animation to the project.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@swaraj-das reminder to review the PR. Please try to review it soon, as otherwise I would have to face a conflict again.

@AnitSarkar123 AnitSarkar123 merged commit a87b301 into swaraj-das:main Oct 7, 2024
2 checks passed
@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 7, 2024

@AnitSarkar123 please assign the PR to me and issue the required labels as stated before.
Also thanks for reviewing the PR.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@swaraj-das Also a friendly reminder from the GSSoC community announcements: image

Please issue the correct tags. Also issue level tag in the corresponding issue #105. Would appreciate a level2 tag since I have updated the code and also added an extra hover animation to the project.

@AnitSarkar123 Please remove the gssoc-extd label as it is a wrong label.

@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 8, 2024

@AnitSarkar123 I have also informed this to swaraj, but I am also informing you, the corresponding issue of this PR does not have the level tag assigned. Please do so and close the Issue #105 of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants