v1.5.1 fixes bug loading settings on new installs (#66)

Co-authored-by: Steven Swartz <[email protected]>
swar8080 · May 28, 2023 · 922228b · 922228b
1 parent 1ad2cfa
commit 922228b
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 5 deletions.
diff --git a/manifest-beta.json b/manifest-beta.json
@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-plugin-update-tracker",
 	"name": "Plugin Update Tracker",
-	"version": "1.5.0",
+	"version": "1.5.1",
 	"minAppVersion": "0.15.0",
 	"description": "Know when installed plugins have updates and evaluate the risk of upgrading",
 	"author": "Obsidian",

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-plugin-update-tracker",
 	"name": "Plugin Update Tracker",
-	"version": "1.5.0",
+	"version": "1.5.1",
 	"minAppVersion": "0.15.0",
 	"description": "Know when installed plugins have updates and evaluate the risk of upgrading",
 	"author": "Obsidian",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "obsidian-plugin-update-tracker",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "Know when installed plugins have updates and evaluate the risk of upgrading",
   "main": "main.js",
   "scripts": {

diff --git a/src/domain/initiatePluginSettings.test.ts b/src/domain/initiatePluginSettings.test.ts
@@ -2,6 +2,12 @@ import initiatePluginSettings from './initiatePluginSettings';
 import { DEFAULT_PLUGIN_SETTINGS, PluginSettings } from './pluginSettings';
 
 describe('initiatePluginSettings', () => {
+    test('loading plugin for first time with null existing settings uses default settings', () => {
+        const settings = initiatePluginSettings(null);
+
+        expect(settings).toEqual(DEFAULT_PLUGIN_SETTINGS);
+    });
+
     test('loading plugin for first time uses default settings', () => {
         const settings = initiatePluginSettings({});
 

diff --git a/src/domain/initiatePluginSettings.ts b/src/domain/initiatePluginSettings.ts
@@ -1,6 +1,9 @@
 import { DEFAULT_PLUGIN_SETTINGS, PluginSettings } from './pluginSettings';
 
-export default function initiateSettings(savedSettings: Partial<PluginSettings>): PluginSettings {
+export default function initiateSettings(
+    savedSettings: Partial<PluginSettings> | null
+): PluginSettings {
+    savedSettings = savedSettings || {};
     const migratedSettings: Partial<PluginSettings> = {};
 
     if (

diff --git a/versions.json b/versions.json
@@ -15,5 +15,6 @@
 	"1.4.4": "0.15.0",
 	"1.4.5": "0.15.0",
 	"1.4.6": "0.15.0",
-	"1.5.0": "0.15.0"
+	"1.5.0": "0.15.0",
+	"1.5.1": "0.15.0"
 }