Feature/chart 5 - creating custom tooltips #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denisfront
changed the title
tany31
reviewed
Jan 18, 2022
tany31
approved these changes
Jan 24, 2022
alexeyvokin
requested changes
Jan 27, 2022
| <div class="wallet-info__optional-buttons"> | ||
| <div class="wallet-info__chart-switcher-wrapper"> | ||
| <swap-switch v-model="isChartView" label="Price chart"></swap-switch> | ||
| <match-media v-slot="{ phone }" tag="div"> |
There was a problem hiding this comment.
можно было использовать inject, чтобы не вносить много изменений
| const tooltipNode = document.createElement('div') | ||
| tooltipNode.className = `swap-chart__tooltip swap-chart__tooltip--${tooltipConf.name}` | ||
| this.$refs.swapChart.appendChild(tooltipNode) | ||
| this.bindedMoveTooltip = this.movementOfTooltip.bind(this, { tooltipNode, tooltipConf }) |
There was a problem hiding this comment.
когда несколько конфигов (а их сейчас несколько), то перетирается метод bindedMoveTooltip
по итогу, в destroyed - очищается обработчик для последнего метода только
| }, | ||
| methods: { | ||
| createTooltips() { | ||
| tooltipsConfiguration.forEach(tooltipConf => { | ||
| const tooltipNode = document.createElement('div') |
There was a problem hiding this comment.
рендер тултипом можно было реализовать через vue, т.е. описать в template
останется только придумать как правильно обработчики добавлять для графика
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.