Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

due to audit https://scrutify.super.site/encore-defi #5215

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

noxonsu
Copy link
Member

@noxonsu noxonsu commented Sep 1, 2023

  1. fix Hardcoded Admin Addresses (ATS-1, ATSE-1)

  2. removed unused FarmFactory and FarmRounter.sol
    these contracts is "custom job" for "phi2" client and not used elsewhere

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

Video / screenshot proof

1. fix Hardcoded Admin Addresses (ATS-1, ATSE-1)

2. removed unused FarmFactory and FarmRounter.sol
these contracts is "custom job" for "phi2" client and not used elsewhere
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c39355
Status:⚡️  Build in progress...

View logs

@noxonsu noxonsu merged commit 4b8f838 into master Sep 1, 2023
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the audit1 branch September 1, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant