Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrencyAction modal - fix receive link #5183

Merged
merged 1 commit into from
Jan 7, 2023
Merged

CurrencyAction modal - fix receive link #5183

merged 1 commit into from
Jan 7, 2023

Conversation

shendel
Copy link
Collaborator

@shendel shendel commented Jan 7, 2023

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

Video / screenshot proof

@shendel
Copy link
Collaborator Author

shendel commented Jan 7, 2023

#5180

@shendel shendel merged commit 43a02e7 into master Jan 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the issue5180p2 branch January 7, 2023 18:20
@Phinetwork
Copy link

Still triggers error when phi v1 chain is not enabled in the backend for phi v2 chain tokens. If only phi v2 chain is enabled in admin backend the phi20 v2 tokens throw an error when go to deposit page,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants