Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue5180 - HotFix. Receive modal for tokens #5182

Merged
merged 8 commits into from
Jan 7, 2023
Merged

Issue5180 - HotFix. Receive modal for tokens #5182

merged 8 commits into from
Jan 7, 2023

Conversation

shendel
Copy link
Collaborator

@shendel shendel commented Jan 6, 2023

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

#5180

Video / screenshot proof

Исправил форму получения адреса кошелька для токенов

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a11d25
Status: ✅  Deploy successful!
Preview URL: https://58966af8.multicurrencywallet-btg.pages.dev
Branch Preview URL: https://issue5180.multicurrencywallet-btg.pages.dev

View logs

@shendel
Copy link
Collaborator Author

shendel commented Jan 7, 2023

Тесты - бинанс блокирует CORS
image

noxonsu
noxonsu approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@noxonsu noxonsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test from phi

@shendel shendel merged commit 2ec172e into master Jan 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the issue5180 branch January 7, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noxonsu noxonsu noxonsu approved these changes

@VitaliyShulik VitaliyShulik Awaiting requested review from VitaliyShulik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shendel @noxonsu