Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cardStyl): Fix Card Height and adjust button position in card #1254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EliasLeguizamon123
Copy link

  • I've checked that this isn't a new swag opportunity proposal.
  • I've checked that this isn't a duplicate pull request.

Fix card component height, adding min height property

BEFORE:

devSwagBefore

AFTER:

devSwagAfter

MOBILE:

devSwagMobile

@EliasLeguizamon123 EliasLeguizamon123 changed the title Fix cards height fix(cardStyl): Fix Card Height and adjust button position in card Jan 20, 2024
@EliasLeguizamon123
Copy link
Author

hi @aslafy-z Could you take a quick look at my PR when you get a chance? I like to hear your thoughts on it, thanks.

@aslafy-z
Copy link
Collaborator

aslafy-z commented Oct 3, 2024

Hello @EliasLeguizamon123
Sorry for this late feedback.
Imo, the rule should not apply to mobile browsers. It makes cards too long for nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants