Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #6340 #9306

Conversation

XprabhatX
Copy link

Description

I made some changes in text content of the authorization component as requested in Issue #6340

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Improvements (misc. changes to existing features)

My changes...

  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.

Automated tests

  • My changes can not or do not need to be tested.

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@char0n
Copy link
Member

char0n commented Nov 21, 2023

The reasoning in #6340 is sound. I just need to verify further some details...

@char0n
Copy link
Member

char0n commented Jan 4, 2024

Closing this for now, as it's not aligned with #6340 (comment)

@char0n char0n closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants