Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): remove explicit Node.js install #10192

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

char0n
Copy link
Member

@char0n char0n commented Nov 5, 2024

No need for explicit Node.js install as the base image comes with [email protected] already.

@char0n char0n self-assigned this Nov 5, 2024
@char0n char0n added type: enhancement cat: docker docker Pull requests that update Docker code labels Nov 5, 2024
@char0n char0n merged commit d849b74 into master Nov 5, 2024
8 checks passed
@Exagone313
Copy link

I think this is a mistake, the nginx:1.27.2-alpine image doesn't contain NodeJS.

@char0n
Copy link
Member Author

char0n commented Nov 6, 2024

Hi @Exagone313,

yes, it was a mistake remedied in https://github.com/swagger-api/swagger-ui/releases/tag/v5.18.1

char0n pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: docker docker Pull requests that update Docker code type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants