-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp DefaultCodegenConfig fromRequestBody() #99
base: master
Are you sure you want to change the base?
Conversation
Hi @HugoMario, I don't think it's actually a problem. (The correct schema is obtained via
Here is the corresponding section of the OpenAPI spec:
|
f77a177
to
c348c0e
Compare
c348c0e
to
42e072c
Compare
This makes the behaviour of `fromRequestBody()` similar to that of `fromParameter()` (by replacing most of the existing code with code from `fromParameter()`) in order to fix a number of issues. Notably this includes a lack of handling for enums, both as references (as can be seen in swagger-api#95) and inline. Also: - Add `postProcessRequestBody()` hook for code generators - Fix swagger-api#95
Previously the `dataType` for the binary format would be set to the default of `Object`. Also: bring the enum check in `fromRequestBody()` up to date with the final code from pull swagger-api#98
42e072c
to
a9d39c9
Compare
Hey @devplayer0, sorry for this delay, i'm wondering what you mean, if it's a problem or not. in case you wanna merge this chance, is it possible you update the PR or you think we can close this one? |
Lack of handling for enum in the requestBody is an issue for me too. Is there any plan to merge this PR? |
This makes the behaviour of
fromRequestBody()
similar to that offromParameter()
(by replacing most of the existing code with code fromfromParameter()
) in order to fix a number of issues. Notably this includes a lack of handling for enums, both as references (as can be seen in #95) and inline.Also:
postProcessRequestBody()
hook for code generators