Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use default default rxjava3 adapter for retrofit2 #954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chadoc
Copy link

@chadoc chadoc commented Sep 8, 2021

When adding support of RxJava3 for Retrofit2 generator, adapter used was a third party library: swagger-api/swagger-codegen#10312

An "official" adapter is provided by squareup itself which follows the versioning of retrofit2. It's probably a better choice to stick to default implementation.

Previously, RxJava3CallAdapterFactory.create() was returning an adapter which was creating synchronous Observables by default. Now, RxJava3CallAdapterFactory.create() returns an adapter which create async Observables by default, that's why I keep previous behaviour, however, maybe we should stick to default behaviour desired by squareup.

@yokrysty
Copy link

proposal: use
RxJava3CallAdapterFactory.createWithScheduler(Schedulers.io())

@yokrysty
Copy link

why is this still not fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants