feat: use default default rxjava3 adapter for retrofit2 #954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support of RxJava3 for Retrofit2 generator, adapter used was a third party library: swagger-api/swagger-codegen#10312
An "official" adapter is provided by squareup itself which follows the versioning of retrofit2. It's probably a better choice to stick to default implementation.
Previously, RxJava3CallAdapterFactory.create() was returning an adapter which was creating synchronous Observables by default. Now, RxJava3CallAdapterFactory.create() returns an adapter which create async Observables by default, that's why I keep previous behaviour, however, maybe we should stick to default behaviour desired by squareup.