Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] Implement #10176 (for 3.x) #667

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

michaelkourlas
Copy link

@michaelkourlas michaelkourlas commented May 4, 2020

Implemented #10176 (from the swagger-codegen repo) for jersey1, jersey2, resttemplate, and okhttp-gson. Each API call now has up to two additional methods:

  • one containing only required parameters
  • one containing required parameters + optional parameters, the latter in a builder-style format

It was necessary to fix a bug where the body parameter did not appear in the requiredParams list.

@michaelkourlas michaelkourlas changed the title Update generators for 3.0.0 [JAVA] Implement #10176 (for 3.x) May 4, 2020
@michaelkourlas
Copy link
Author

@HugoMario @frantuma

@jayMcoder
Copy link

jayMcoder commented May 20, 2021

@michaelkourlas - Solution looks neat. One of the API that I consume has 10 optional parameters and I had to set null for all of them. Can this be added to the resttemplate type as well?

@michaelkourlas
Copy link
Author

I'd like the maintainers to confirm whether they're interested in merging this PR before I make any further additions.

@HugoMario
Copy link
Contributor

hey @michaelkourlas thanks for this PR, let me know once is ready to review it and merge it

@michaelkourlas
Copy link
Author

@HugoMario I've added support for this pattern for resttemplate as requested, so I believe this PR (as well as this one and this one) are ready to be reviewed.

@michaelkourlas
Copy link
Author

@HugoMario Just notifying you that this PR (as well as this one and this one) are ready to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants